Service overview e2e test #125359

MiriamAparicio · 2022-02-11T11:00:03Z

Added e2e test for service overview as part of #116417

when navigating to the service overview

and selecting a different environment

API calls are made with the selected environment

and clicking the refresh button

API calls are made with the updated time range

and selecting a different time range

API calls are made with the updated time range
and clicking the refresh button
- API calls are made with the updated time range

and selecting a different comparison window

API calls are made with the updated comparison time range

elasticmachine · 2022-02-11T11:00:05Z

Pinging @elastic/apm-ui (Team:apm)

MiriamAparicio · 2022-02-11T11:02:31Z

@elasticmachine merge upstream

cauemarcondes · 2022-02-11T14:14:43Z

...ins/apm/ftr_e2e/cypress/integration/read_only_user/service_overview/service_overview.spec.ts

+    it('when clicking the refresh button', () => {
+      cy.wait(aliasNames, { requestTimeout: 10000 });
+      cy.contains('Refresh').click();
+      cy.wait(aliasNames);
+    });


Shouldn't it expect something after clicking on refresh?

cauemarcondes · 2022-02-11T14:15:44Z

...ins/apm/ftr_e2e/cypress/integration/read_only_user/service_overview/service_overview.spec.ts

+    it('when selecting a different time range and clicking the update button', () => {
+      cy.wait(aliasNames, { requestTimeout: 10000 });
+
+      cy.selectAbsoluteTimeRange(
+        'Oct 10, 2021 @ 01:00:00.000',
+        'Oct 10, 2021 @ 01:30:00.000'
+      );
+      cy.contains('Update').click();
+      cy.wait(aliasNames, { requestTimeout: 10000 });
+
+      cy.contains('Refresh').click();
+      cy.wait(aliasNames, { requestTimeout: 10000 });
+    });


Here as well?

Maybe you could do something like:

cy.expectAPIsToHaveBeenCalledWith({ apisIntercepted: aliasNames, value: 'start=xxxx&end=zzz });

cauemarcondes · 2022-02-11T14:16:19Z

...ins/apm/ftr_e2e/cypress/integration/read_only_user/service_overview/service_overview.spec.ts

+    it('when selecting a different comparison window', () => {
+      cy.get('[data-test-subj="comparisonSelect"]').should('have.value', 'day');
+
+      // selects another comparison type
+      cy.get('[data-test-subj="comparisonSelect"]').select('week');
+      cy.get('[data-test-subj="comparisonSelect"]').should(
+        'have.value',
+        'week'
+      );
+      cy.wait(aliasNames, { requestTimeout: 10000 });
+    });


and here:

cy.expectAPIsToHaveBeenCalledWith({ apisIntercepted: aliasNames, value: 'comparisonStart=... });

I need to do it just for the endpoint that use the comparison, I'm going to split the request in two lists

cauemarcondes · 2022-02-11T14:17:07Z

...k/plugins/apm/public/components/app/service_overview/service_overview_errors_table/index.tsx

+    <div data-test-subj="serviceOverviewErrorsTable">
+      <EuiFlexGroup direction="column" gutterSize="s">


Is this extra div really necessary?

Suggested change

<div data-test-subj="serviceOverviewErrorsTable">

<EuiFlexGroup direction="column" gutterSize="s">

<EuiFlexGroup direction="column" gutterSize="s" data-test-subj="serviceOverviewErrorsTable">

cauemarcondes · 2022-02-11T14:17:27Z

...lugins/apm/public/components/app/service_overview/service_overview_instances_table/index.tsx

+    <div data-test-subj="serviceOverviewInstancesTable">
+      <EuiFlexGroup direction="column" gutterSize="s">


Suggested change

<div data-test-subj="serviceOverviewInstancesTable">

<EuiFlexGroup direction="column" gutterSize="s">

<EuiFlexGroup direction="column" gutterSize="s" data-test-subj="serviceOverviewInstancesTable">

cauemarcondes · 2022-02-11T14:17:46Z

x-pack/plugins/apm/public/components/shared/dependencies_table/index.tsx

+    <div data-test-subj="dependenciesTable">
+      <EuiFlexGroup direction="column" gutterSize="s">


Suggested change

<div data-test-subj="dependenciesTable">

<EuiFlexGroup direction="column" gutterSize="s">

<EuiFlexGroup direction="column" gutterSize="s" data-test-subj="dependenciesTable">

cauemarcondes · 2022-02-11T14:17:59Z

x-pack/plugins/apm/public/components/shared/transactions_table/index.tsx

+    <div data-test-subj="transactionsGroupTable">
+      <EuiFlexGroup direction="column" gutterSize="s">


Suggested change

<div data-test-subj="transactionsGroupTable">

<EuiFlexGroup direction="column" gutterSize="s">

<EuiFlexGroup direction="column" gutterSize="s" data-test-subj="transactionsGroupTable">

cauemarcondes

Added some suggestions, let me know what you think.

gbamparop

Thanks for adding all these tests! I've added some comments on the PR

...ins/apm/ftr_e2e/cypress/integration/read_only_user/service_overview/service_overview.spec.ts

MiriamAparicio · 2022-02-14T08:52:30Z

@elasticmachine merge upstream

MiriamAparicio · 2022-02-14T14:35:48Z

...ins/apm/ftr_e2e/cypress/integration/read_only_user/service_overview/service_overview.spec.ts

-      'have.value',
-      'Worker'
-    );
+  describe('transactions', () => {


I kept these tests for the transactions because they were already there, but I think we need to create a specific test file for the transactions flow
What do you think @cauemarcondes @gbamparop ?

Or test all the tabs flow here

From what I can see, where are testing if the transaction type is persisted when navigating from service overview to something else, so IMO it makes sense to keep it here. What you could do is to improve the describe title.

cauemarcondes

LGTM

MiriamAparicio · 2022-02-15T08:16:56Z

@elasticmachine merge upstream

kibana-ci · 2022-02-15T09:49:43Z

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`apm`	2.7MB	2.7MB	+175.0B

History

💔 Build #23904 failed 2bbbd1b
💔 Build #23782 failed 07676c2926a18d149ad194edfb19824c10e9d0c4
💚 Build #23441 succeeded 3a669613b5a75f934d7514dd2fd90e43ef43be86

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

gbamparop

LGTM!

kibanamachine · 2022-02-15T11:07:19Z

The following labels were identified as gaps in your version labels and will be added automatically:

v8.2.0

If any of these should not be on your pull request, please manually remove them.

* Add e2e test for service overview * add test for comparison type change * PR review comments addressed * improve time range test Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit 0e87ffc)

kibanamachine · 2022-02-15T11:10:00Z

💚 All backports created successfully

Status	Branch	Result
✅	8.1

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

…pdf-generation-in-worker-thread * 'main' of github.com:elastic/kibana: (40 commits) Service overview e2e test (elastic#125359) [Graph] Make graph edges easier to click (elastic#124053) [Reporting] Add additional PNG and PDF metrics (elastic#125450) [APM] Lint rule for explicit return types (elastic#124771) [SecuritySolution] Enrich threshold data from correct fields (elastic#125376) [Uptime monitor management] Make index template installation retry (elastic#125537) [Console] Support suggesting index templates v2 (elastic#124655) [Logs UI] Support switching between log source modes (elastic#124929) SavedObjects management: change index patterns labels to data views (elastic#125356) [ci-stats] add Client class for accessing test group stats (elastic#125164) [ML] Use Discover locator in Data Visualizer instead of URL Generator (elastic#124283) [Fleet] Add retries when starting docker registry in integration tests (elastic#125530) Update osquery.asciidoc to address doc issue (elastic#125425) synthetics e2e - use custom location when defined (elastic#125560) [ci] Retry failed steps in on-merge pipeline (elastic#125550) [babel] Bump babel packages (elastic#125446) [DOCS] Updates Upgrade Assistant API status (elastic#125410) [DOCS] Minor tweaks to upgrade docs (elastic#125538) [Uptime] handle null duration on ping list (elastic#125438) [TSVB][Lens] Navigate to Lens with your current configuration (elastic#114794) ... # Conflicts: # x-pack/plugins/reporting/server/export_types/common/pdf/pdfmaker.ts # x-pack/plugins/reporting/server/export_types/printable_pdf/lib/generate_pdf.ts # x-pack/plugins/reporting/server/export_types/printable_pdf_v2/lib/generate_pdf.ts

* Add e2e test for service overview * add test for comparison type change * PR review comments addressed * improve time range test Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit 0e87ffc) Co-authored-by: Miriam <[email protected]>

MiriamAparicio added Team:APM All issues that need APM UI Team support release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v8.1.0 labels Feb 11, 2022

MiriamAparicio requested a review from a team as a code owner February 11, 2022 11:00

MiriamAparicio mentioned this pull request Feb 11, 2022

[APM] Missing tests for flow: Service inventory -> Service overview -> Transaction #116417

Closed

3 tasks

cauemarcondes reviewed Feb 11, 2022

View reviewed changes

cauemarcondes requested changes Feb 11, 2022

View reviewed changes

gbamparop requested changes Feb 11, 2022

View reviewed changes

...ins/apm/ftr_e2e/cypress/integration/read_only_user/service_overview/service_overview.spec.ts Outdated Show resolved Hide resolved

...ins/apm/ftr_e2e/cypress/integration/read_only_user/service_overview/service_overview.spec.ts Outdated Show resolved Hide resolved

MiriamAparicio added 3 commits February 14, 2022 12:58

Add e2e test for service overview

d32f7ad

add test for comparison type change

2bdfb05

PR review comments addressed

2a63a21

MiriamAparicio force-pushed the service-overview-2e2-test branch from 07676c2 to 2a63a21 Compare February 14, 2022 14:17

improve time range test

2bbbd1b

MiriamAparicio commented Feb 14, 2022

View reviewed changes

cauemarcondes approved these changes Feb 14, 2022

View reviewed changes

sorenlouv changed the title ~~Service overview 2e2 test~~ Service overview e2e test Feb 14, 2022

Merge branch 'main' into service-overview-2e2-test

2d16ad7

MiriamAparicio requested a review from gbamparop February 15, 2022 08:20

gbamparop approved these changes Feb 15, 2022

View reviewed changes

MiriamAparicio merged commit 0e87ffc into elastic:main Feb 15, 2022

kibanamachine added the backport:skip This commit does not require backporting label Feb 15, 2022

MiriamAparicio deleted the service-overview-2e2-test branch February 15, 2022 11:07

kibanamachine added the v8.2.0 label Feb 15, 2022

kibanamachine mentioned this pull request Feb 15, 2022

[8.1] Service overview e2e test (#125359) #125628

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Service overview e2e test #125359

Service overview e2e test #125359

MiriamAparicio commented Feb 11, 2022

elasticmachine commented Feb 11, 2022

MiriamAparicio commented Feb 11, 2022

cauemarcondes Feb 11, 2022

cauemarcondes Feb 11, 2022

cauemarcondes Feb 11, 2022

MiriamAparicio Feb 11, 2022

cauemarcondes Feb 11, 2022

cauemarcondes Feb 11, 2022

cauemarcondes Feb 11, 2022

cauemarcondes Feb 11, 2022

cauemarcondes left a comment

gbamparop left a comment

MiriamAparicio commented Feb 14, 2022

MiriamAparicio Feb 14, 2022 •

edited

Loading

MiriamAparicio Feb 14, 2022

cauemarcondes Feb 14, 2022

cauemarcondes left a comment

MiriamAparicio commented Feb 15, 2022

kibana-ci commented Feb 15, 2022

gbamparop left a comment

kibanamachine commented Feb 15, 2022

kibanamachine commented Feb 15, 2022

		<div data-test-subj="serviceOverviewErrorsTable">
		<EuiFlexGroup direction="column" gutterSize="s">

		<div data-test-subj="serviceOverviewInstancesTable">
		<EuiFlexGroup direction="column" gutterSize="s">

		<div data-test-subj="dependenciesTable">
		<EuiFlexGroup direction="column" gutterSize="s">

		<div data-test-subj="transactionsGroupTable">
		<EuiFlexGroup direction="column" gutterSize="s">

Service overview e2e test #125359

Service overview e2e test #125359

Conversation

MiriamAparicio commented Feb 11, 2022

elasticmachine commented Feb 11, 2022

MiriamAparicio commented Feb 11, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cauemarcondes left a comment

Choose a reason for hiding this comment

gbamparop left a comment

Choose a reason for hiding this comment

MiriamAparicio commented Feb 14, 2022

MiriamAparicio Feb 14, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cauemarcondes left a comment

Choose a reason for hiding this comment

MiriamAparicio commented Feb 15, 2022

kibana-ci commented Feb 15, 2022

💚 Build Succeeded

Metrics [docs]

Async chunks

History

gbamparop left a comment

Choose a reason for hiding this comment

kibanamachine commented Feb 15, 2022

kibanamachine commented Feb 15, 2022

💚 All backports created successfully

Questions ?

MiriamAparicio Feb 14, 2022 •

edited

Loading